[PATCH] D21101: [exceptions] Upgrade exception handlers when stack protector is used
David Majnemer via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 10 14:25:13 PDT 2016
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/CodeGen/WinEHPrepare.cpp:107-110
@@ -105,2 +106,6 @@
return false;
+ // When stack-protector is present, some exception handlers need to be
+ // promoted to a compatible handlers.
+ promoteEHPersonality(Fn);
+
----------------
I think it would make sense to sink this call into `prepareExplicitEH`.
http://reviews.llvm.org/D21101
More information about the llvm-commits
mailing list