[lld] r272305 - Use errorDynRel like every other target.

[George Rimar via llvm-commits]

>>

>> So, after this change + r272303 ("Also reject 32 bit dynamic relocs when producing executable."),
>> error message says "cannot be used when making a shared object", but for example
>> x86-64-dyn-rel-error.s does not link DSO, it links executable and error message looks confusing.
>>
>> Shouldn't  we change the part saying we making shared object to something about that relocations
>> against shared symbol can't be one of these ?

>Yes, something saying that the problem is that that particular relocation cannot point to dynamic symbols would be awesome!

>Cheers,
>Rafael


So can we just change the text "relocation XXX cannot be used when making a shared object; recompile with -fPIC."

to "cannot be used against shared object; recompile with -fPIC." in errorDynRel() ?


For x64 that should work I think. Not sure if there another reasons to error out particular relocation except

possible overflow in runtime ?

?

George.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160610/3f4d2322/attachment.html>