[PATCH] D20639: SLPVectorizer: Move propagateMetadata to VectorUtils
Justin Lebar via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 10 13:38:34 PDT 2016
jlebar added inline comments.
================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:684
@@ -683,3 @@
-
- To->setMetadata(Kind, M.second);
- }
----------------
jlebar wrote:
> Oh, I bet I see the problem. There's a difference in behavior between this propagateMetadata and the new one. This one ignores unknown metadata -- leaves it in place on "To". The new one explicitly removes it.
Oh, that's not quite right -- in the event that you pass just one element for "from" to the new propagateMetadata, propagates *everything*. The new propagateMetadata only removes unknown md if there are multiple "from"s.
http://reviews.llvm.org/D20639
More information about the llvm-commits
mailing list