[PATCH] D21165: Disable MSan-hostile loop unswitching.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 11:47:35 PDT 2016


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM with a minor tweak below.


================
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:532-533
@@ -526,1 +531,4 @@
 
+  bool SanitizingMemory = currentLoop->getHeader()->getParent()->hasFnAttribute(
+      Attribute::SanitizeMemory);
+
----------------
We have a member variable for optimizing for size, I would make this a member variable. That way you can initialize it once above for the function (with cleaner syntax) and then just re-use it everywhere.


Repository:
  rL LLVM

http://reviews.llvm.org/D21165





More information about the llvm-commits mailing list