[PATCH] D21184: [ELF] - Properly check that R_X86_64_PC32 and R_X86_64_32 relocations are disallowed in DSO.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 10 01:21:53 PDT 2016
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272379: [ELF] - Properly check that R_X86_64_PC32 and R_X86_64_32 relocations areā¦ (authored by grimar).
Changed prior to commit:
http://reviews.llvm.org/D21184?vs=60178&id=60325#toc
Repository:
rL LLVM
http://reviews.llvm.org/D21184
Files:
lld/trunk/test/ELF/x86-64-reloc-32-fpic.s
lld/trunk/test/ELF/x86-64-reloc-pc32-fpic.s
Index: lld/trunk/test/ELF/x86-64-reloc-32-fpic.s
===================================================================
--- lld/trunk/test/ELF/x86-64-reloc-32-fpic.s
+++ lld/trunk/test/ELF/x86-64-reloc-32-fpic.s
@@ -1,6 +1,7 @@
# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
# RUN: not ld.lld -shared %t.o -o %t.so 2>&1 | FileCheck %s
-# CHECK: can't create dynamic relocation R_X86_64_32 against readonly segment
+# CHECK: relocation R_X86_64_32 cannot be used when making a shared object; recompile with -fPIC.
+.data
.long _shared
Index: lld/trunk/test/ELF/x86-64-reloc-pc32-fpic.s
===================================================================
--- lld/trunk/test/ELF/x86-64-reloc-pc32-fpic.s
+++ lld/trunk/test/ELF/x86-64-reloc-pc32-fpic.s
@@ -1,6 +1,7 @@
# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
# RUN: not ld.lld -shared %t.o -o %t.so 2>&1 | FileCheck %s
-# CHECK: can't create dynamic relocation R_X86_64_PC32 against readonly segment
+# CHECK: relocation R_X86_64_PC32 cannot be used when making a shared object; recompile with -fPIC.
+.data
call _shared
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21184.60325.patch
Type: text/x-patch
Size: 1159 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160610/bf704bc6/attachment.bin>
More information about the llvm-commits
mailing list