[PATCH] D21018: [ELF] - Basic versioned symbols support implemented.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 00:29:36 PDT 2016


grimar added a comment.

In http://reviews.llvm.org/D21018#453725, @ruiu wrote:

> For some reason, I received no email notifications on this review thread. George, do you have an idea why?


I think the only difference here from my usual style was that I quoted the part of your message and posted responce "Thanks for review ! My response to comments are below." in the same message with responces on review comments. Usually I think I do not do that and comments just auto merged to the last (patch updated) post. I am always using web form for that, so no much ways to do almost the same here exist.

Not sure that it can be the reason, I added you as a subscriber just in case as well, hope that helps.

> I haven't fully understand the core part of the patch yet, so this review is mostly on stylistic things. I'll read it again later today or tomorrow. (I'm traveling for a few days until Sunday.)


Ok, just in case I think I`ll also be able to address any comments for this in next 2 days if any.


http://reviews.llvm.org/D21018





More information about the llvm-commits mailing list