[PATCH] D21180: [IPRA] Interprocedural Register Allocation - Transformation Pass

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.

================
Comment at: lib/CodeGen/RegUsageInfoPropagate.cpp:109
@@ +108,3 @@
+
+        auto UpdateRegMask = [&](StringRef FuncName) {
+          const auto *RegMask = PRUI->getRegUsageInfo(M->getFunction(FuncName));
----------------
Take a Function * as argument here, and adapt call sites.

================
Comment at: lib/CodeGen/RegUsageInfoPropagate.cpp:122
@@ +121,3 @@
+          UpdateRegMask(Operand.getSymbolName());
+        }
+
----------------
no braces

================
Comment at: test/CodeGen/Generic/ipra-transform.ll:11
@@ +10,3 @@
+define preserve_allcc void @foo()#0 {
+; NOIPRA-LABEL: foo:
+; NOIPRA: pushq	%r10
----------------
Add some comment in the test describing what you're checking in both cases.


http://reviews.llvm.org/D21180