[PATCH] D21110: [CFLAA] Add yet another StratifiedAttr

[George Burgess IV via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

LGTM. Will commit.


================
Comment at: lib/Analysis/CFLAliasAnalysis.cpp:1024
@@ +1023,3 @@
+      // TODO: do we need to filter out non-pointer values here?
+      Builder.addAttributesBelow(&Val, AttrUnknown);
+    }
----------------
Insertion shouldn't be a problem, since the only things we insert after the declaration of this are isolated nodes. Also, I think merging should be fine, since we never actually merge attributes, but I could be wrong.

Either way, I'm happy to leave this as-is and revisit it if it becomes a problem (since the worst case seems to be that we end up with a handful of "useless" bytes in a StratifiedSets instance)

================
Comment at: test/Analysis/CFLAliasAnalysis/attr-escape.ll:6
@@ -5,5 +5,3 @@
 
-; CHECK: Function: escape_ptrtoint
-; CHECK: NoAlias: i32* %a, i32* %x
-; CHECK: NoAlias: i32* %b, i32* %x
+; CHECK-LABEL: Function: test_local
 ; CHECK: NoAlias: i32* %a, i32* %b
----------------
I'll fix them to be less bad, then. Thanks for the heads-up :)


http://reviews.llvm.org/D21110