[PATCH] D21189: Create subranges for new intervals resulting from live interval splitting

[Quentin Colombet via llvm-commits]

qcolombet added a comment.

Hi Krzysztof,

Looks mostly good to me, I do not think the assert I’ve pointed out is correct though.

Cheers,
-Quentin


================
Comment at: lib/CodeGen/SplitKit.cpp:1147
@@ +1146,3 @@
+    if (LI->hasSubRanges()) {
+      LiveRangeCalc C;
+      unsigned Sub = MO.getSubReg();
----------------
Change the name to SubLRC

================
Comment at: lib/CodeGen/VirtRegMap.cpp:339
@@ -338,2 +338,3 @@
          "Reads of completely dead register should be marked undef already");
+  assert(LI.hasSubRanges());
   unsigned SubRegIdx = MO.getSubReg();
----------------
I believe the assertion should be on SubRegIdx != 0, because hasSubRanges is only populated when we have sub register liveness enabled.


Repository:
  rL LLVM

http://reviews.llvm.org/D21189