[PATCH] D19852: [safestack] Use non-thread-local unsafe stack pointer for Contiki OS

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 12:02:16 PDT 2016


eugenis added inline comments.

================
Comment at: include/llvm/ADT/Triple.h:166
@@ -165,2 +165,3 @@
     ELFIAMCU,
+    Contiki,
     TvOS,       // Apple tvOS
----------------
Please add to the end of the list.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:1940
@@ -1939,1 +1939,3 @@
 Value *X86TargetLowering::getSafeStackPointerLocation(IRBuilder<> &IRB) const {
+  if (Subtarget.isTargetContiki()) {
+    const char *Name = "__safestack_unsafe_stack_ptr";
----------------
Why duplicate all this code instead of just checking for isTargetContiki is SafeStack.cpp?


http://reviews.llvm.org/D19852





More information about the llvm-commits mailing list