[PATCH] D21045: Use ProfileSummaryInfo in inline cost analysis

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 11:53:26 PDT 2016


eraman added a comment.

In http://reviews.llvm.org/D21045#450495, @silvas wrote:

> Strictly speaking, I don't think this is NFC (e.g. it required changing the tests). But it seems straightforward enough.


Sorry, I meant it in the sense of it doesn't change the functionality of inliner.

David, IIRC patches need an explicit LGTM before submitting and accepting the patch in phabricator is not enough.


http://reviews.llvm.org/D21045





More information about the llvm-commits mailing list