[PATCH] D21103: optimized xsgetn for better performance

Marshall Clow via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 09:41:06 PDT 2016


mclow.lists added a comment.

Other than the `min` thing, this looks good to me.


================
Comment at: libcxx/include/streambuf:502
@@ +501,3 @@
+        {
+            const streamsize __len = std::min(__einp_ - __ninp_, __n - __i);
+            traits_type::copy(__s, __ninp_, __len);
----------------
Please use `_VSTD::min` instead of `std::min`


http://reviews.llvm.org/D21103





More information about the llvm-commits mailing list