[PATCH] D21182: [AArch64] Restore codegen for AArch64 Cortex-A72/A73 after NFCI

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 08:42:25 PDT 2016


sbaranga added a comment.

In http://reviews.llvm.org/D21182#453416, @rengolin wrote:

> In http://reviews.llvm.org/D21182#453412, @sbaranga wrote:
>
> > I suspect what we really want are tests for these features that aren't triggered by -mcpu=... (which is probably how they were initially added).
>
>
> Can you add CPU features in command lines? Like:
>
>   -march=armv8a+FeaturePredictableSelectIsExpensive
>   
>
> If not, the only way to test those features is by selecting a CPU that has it versus one that hasn't.


They can be turned on/off with -mattr:

bin/llc ../llvm/test/Transforms/InstCombine/phi-preserve-ir-flags.ll  -o - -mtriple=aarch64-linux-gnueabi -mattr=+merge-narrow-ld
bin/llc ../llvm/test/Transforms/InstCombine/phi-preserve-ir-flags.ll  -o - -mtriple=aarch64-linux-gnueabi -mattr=-merge-narrow-ld


http://reviews.llvm.org/D21182





More information about the llvm-commits mailing list