[PATCH] D16635: Fix PR #12906: printing of floating-point constants on non-C locales

[James Y Knight via llvm-commits]

jyknight added a comment.

> I know this patch is a bit hard to swallow given the number of trivial changes in the test suite, but it would be nice to get feedback, at least on the overall approach. As fas as I can tell, the bug is still present in git master.


It looks fine to me, except as you say the large number of test changes make it scary. It seems to me that it'd be nice to preserve the existing output (via an argument passed to APFloat::toString), just for sanity's sake even though it's not required for compatibility or anything.

Dunno if others agree?


http://reviews.llvm.org/D16635