[PATCH] D21011: [codeview] Add complex record type translation

Amjad Aboud via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 06:40:00 PDT 2016


aaboud added a comment.

In http://reviews.llvm.org/D21011#453066, @rnk wrote:

> I still feel like this patch is too large and is trying to do too much. Can we limit it to just handling non-virtual methods and their overloads? I don't want to review the VBPtr offset computation code at the same time as bitfields and virtual bases and etc etc. Each of those things requires a certain amount of care.


OK, this is what I am going to do:

1. Update (rebase) this patch to top of trunk (no other changes will be made) and will upload the patch.
2. I will remove remove from the patch the handling of bitfield, VBPtr, virtual inheritance, etc. and will apply relevant comments.

I am doing (1) so we still have a reference for this code (updated to top of trunk).
I will upload these patches soon today.


http://reviews.llvm.org/D21011





More information about the llvm-commits mailing list