[PATCH] D21178: Add mrrc/mrrc2 co-processor intrinsics
Renato Golin via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 9 05:15:52 PDT 2016
rengolin added inline comments.
================
Comment at: lib/Target/ARM/Disassembler/ARMDisassembler.cpp:5285
@@ -5284,1 +5284,3 @@
+ if (Inst.getOpcode() == ARM::MRRC2) {
+ if (!Check(S, DecodeGPRnopcRegisterClass(Inst, Rt, Address, Decoder)))
----------------
This looks like a different change, for another patch.
Also, why only validate for MRRC and MCRR? Were the checks wrong for the rest?
If so, why not just have one check if MRRC || MCRR?
http://reviews.llvm.org/D21178
More information about the llvm-commits
mailing list