[PATCH] D21142: [PDB] Move PDB functions to a separate file.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 16:00:11 PDT 2016


ruiu added inline comments.

================
Comment at: lib/DebugInfo/PDB/Raw/Hash.cpp:22
@@ +21,3 @@
+  uint32_t Result = 0;
+  uint32_t Size = Str.size();
+
----------------
It shouldn't be that large as Str always points to a string in PDB (in which all streams are at most 2^32 bytes.)

================
Comment at: lib/DebugInfo/PDB/Raw/Hash.cpp:31
@@ +30,3 @@
+  const uint8_t *Remainder = reinterpret_cast<const uint8_t *>(Longs.end());
+  uint32_t RemainderSize = Size - Longs.size() * 4;
+
----------------
Done.


http://reviews.llvm.org/D21142





More information about the llvm-commits mailing list