[PATCH] D21112: [LoopSimplify] Preserve LCSSA when merging exit blocks.

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 15:57:39 PDT 2016


sanjoy accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: lib/Transforms/Utils/LoopSimplify.cpp:795
@@ +794,3 @@
+    assert(
+        all_of(*LI, [&](Loop *L) { return L->isRecursivelyLCSSAForm(*DT); }) &&
+        "Requested to preserve LCSSA, but it's already broken.");
----------------
The indent looks weird -- did you clang-format?

Note: since you're inside an `NDEBUG` it is fine to pull out the computation to outside the assert.

================
Comment at: lib/Transforms/Utils/LoopSimplify.cpp:808
@@ +807,3 @@
+        all_of(*LI, [&](Loop *L) { return L->isRecursivelyLCSSAForm(*DT); }) &&
+        "LCSSA is broken after loop-simplify.");
+#endif
----------------
Ditto.


http://reviews.llvm.org/D21112





More information about the llvm-commits mailing list