[llvm] r272220 - [CMake] Cleanup version check for 2.8.11

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 15:48:13 PDT 2016


Author: cbieneman
Date: Wed Jun  8 17:48:12 2016
New Revision: 272220

URL: http://llvm.org/viewvc/llvm-project?rev=272220&view=rev
Log:
[CMake] Cleanup version check for 2.8.11

We are always greater than CMake 2.8.11, so we don't need this check.

Modified:
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=272220&r1=272219&r2=272220&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Wed Jun  8 17:48:12 2016
@@ -227,14 +227,12 @@ if( MSVC )
   
   include(ChooseMSVCCRT)
 
-  if( NOT (${CMAKE_VERSION} VERSION_LESS 2.8.11) )
-    # set stack reserved size to ~10MB
-    # CMake previously automatically set this value for MSVC builds, but the
-    # behavior was changed in CMake 2.8.11 (Issue 12437) to use the MSVC default
-    # value (1 MB) which is not enough for us in tasks such as parsing recursive
-    # C++ templates in Clang.
-    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /STACK:10000000")
-  endif()
+  # set stack reserved size to ~10MB
+  # CMake previously automatically set this value for MSVC builds, but the
+  # behavior was changed in CMake 2.8.11 (Issue 12437) to use the MSVC default
+  # value (1 MB) which is not enough for us in tasks such as parsing recursive
+  # C++ templates in Clang.
+  set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /STACK:10000000")
 
   if( MSVC11 )
     add_llvm_definitions(-D_VARIADIC_MAX=10)




More information about the llvm-commits mailing list