[PATCH] D20957: [JumpThreading] Prevent dangling pointer problems in BranchProbabilityInfo

[Sanjoy Das via llvm-commits]

sanjoy added subscribers: congh, dnovillo.

================
Comment at: lib/Analysis/BranchProbabilityInfo.cpp:644
@@ +643,3 @@
+  for (auto I = Probs.begin(), E = Probs.end(); I != E; ++I) {
+    auto Key = I->first;
+    if (Key.first == BB)
----------------
I see, but I'm not sure that this won't be a compile time regression.  Maybe @dnovillo or @congh (names that show up on git-blame) will have an idea?

================
Comment at: unittests/Analysis/BlockFrequencyInfoTest.cpp:58
@@ +57,3 @@
+
+  void releaseBFI() {
+    // Prevent AssertingVH from failing.
----------------
In that case, let's call it `destroyBFI`?


http://reviews.llvm.org/D20957