[llvm] r272186 - [CodeView] Remove manual expansion of the default copy ctor.

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 11:19:38 PDT 2016


Author: d0k
Date: Wed Jun  8 13:19:38 2016
New Revision: 272186

URL: http://llvm.org/viewvc/llvm-project?rev=272186&view=rev
Log:
[CodeView] Remove manual expansion of the default copy ctor.

It provides nothing over the default one but makes the class not
trivially copyable. No functionality change intended.

Modified:
    llvm/trunk/include/llvm/DebugInfo/CodeView/StreamRef.h

Modified: llvm/trunk/include/llvm/DebugInfo/CodeView/StreamRef.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/CodeView/StreamRef.h?rev=272186&r1=272185&r2=272186&view=diff
==============================================================================
--- llvm/trunk/include/llvm/DebugInfo/CodeView/StreamRef.h (original)
+++ llvm/trunk/include/llvm/DebugInfo/CodeView/StreamRef.h Wed Jun  8 13:19:38 2016
@@ -25,9 +25,6 @@ public:
       : Stream(&Stream), ViewOffset(Offset), Length(Length) {}
 
   StreamRef(const StreamRef &Stream, uint32_t Offset, uint32_t Length) = delete;
-  StreamRef(const StreamRef &Other)
-      : Stream(Other.Stream), ViewOffset(Other.ViewOffset),
-        Length(Other.Length) {}
 
   Error readBytes(uint32_t Offset, uint32_t Size,
                   ArrayRef<uint8_t> &Buffer) const override {
@@ -68,13 +65,6 @@ public:
 
   bool operator!=(const StreamRef &Other) const { return !(*this == Other); }
 
-  StreamRef &operator=(const StreamRef &Other) {
-    Stream = Other.Stream;
-    ViewOffset = Other.ViewOffset;
-    Length = Other.Length;
-    return *this;
-  }
-
 private:
   const StreamInterface *Stream;
   uint32_t ViewOffset;




More information about the llvm-commits mailing list