[llvm] r272184 - Attempt #2 to appease the buildbots.

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 10:56:35 PDT 2016


Author: gbiv
Date: Wed Jun  8 12:56:35 2016
New Revision: 272184

URL: http://llvm.org/viewvc/llvm-project?rev=272184&view=rev
Log:
Attempt #2 to appease the buildbots.

MSVC calls the copy ctor on StratifiedSets for some reason. So,
undelete it.

Modified:
    llvm/trunk/lib/Analysis/StratifiedSets.h

Modified: llvm/trunk/lib/Analysis/StratifiedSets.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/StratifiedSets.h?rev=272184&r1=272183&r2=272184&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/StratifiedSets.h (original)
+++ llvm/trunk/lib/Analysis/StratifiedSets.h Wed Jun  8 12:56:35 2016
@@ -94,9 +94,9 @@ struct StratifiedLink {
 template <typename T> class StratifiedSets {
 public:
   StratifiedSets() = default;
-  // If we have a need to copy these at some point, it's fine to default this.
-  // At the time of writing, copying StratifiedSets is always a perf bug.
-  StratifiedSets(const StratifiedSets &) = delete;
+
+  // TODO: Figure out how to make MSVC not call the copy ctor here, and delete
+  // it.
 
   // Can't default these due to compile errors in MSVC2013
   StratifiedSets(StratifiedSets &&Other) { *this = std::move(Other); }




More information about the llvm-commits mailing list