[PATCH] D21083: [sanitizer][esan] Add internal_sigaction_syscall

Derek Bruening via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 10:31:42 PDT 2016


bruening added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:683
@@ +682,3 @@
+    k_act.sa_flags = u_act->sa_flags | SA_RESTORER;
+#if !SANITIZER_ANDROID || !SANITIZER_MIPS32
+    k_act.sa_restorer = u_act->sa_restorer;
----------------
Please elaborate: you're saying there are variables available to get the platform and that's preferable to the preprocessor defines?  These preprocessor defines are what all the surrounding routines are using for this same type of code, so I'm not sure what other method you're suggesting.


http://reviews.llvm.org/D21083





More information about the llvm-commits mailing list