[PATCH] D21114: [DebugInfo] Add calling convention support for DWARF and CodeView

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 10:29:44 PDT 2016


rnk added inline comments.

================
Comment at: include/llvm/IR/DebugInfoMetadata.h:959
@@ -951,1 +958,3 @@
 
+  unsigned getCC() const { return CC; }
+
----------------
majnemer wrote:
> DebugInfoMetadata.h includes Dwarf.h, can we make this return an `enum CallingConvention`?
I considered it, but that would not be consistent with the other methods for getting the DW_LANG_, etc. I thought maybe there was a reason for that. Also, we can narrow this down to a byte all around whether we go with the enum or not.


http://reviews.llvm.org/D21114





More information about the llvm-commits mailing list