[PATCH] D21142: [PDB] Move PDB functions to a separate file.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 10:19:25 PDT 2016


zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

There is also `SigForPbCb` in Microsoft headers.  I haven't ported this one over yet, and I don't know the details about when each particular function is used.

If possible, could you add a comment over each function in `Hash.h` that briefly documents the situations in which that particular is used?  i.e. what types of records, Tpi Stream version, etc.  We can improve the comments as we learn more, but it would be nice for someone to look at the header file and have a general idea of why there are so many different hash functions.


http://reviews.llvm.org/D21142





More information about the llvm-commits mailing list