[PATCH] D21107: Generate codeview for array types

Adrian McCarthy via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 09:39:30 PDT 2016


amccarth marked 2 inline comments as done.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:788
@@ +787,3 @@
+  uint64_t Size = Ty->getSizeInBits() / 8;
+  ArrayRecord Record(ElementTypeIndex, IndexType, Size, Ty->getName());
+  return TypeTable.writeArray(Record);
----------------
rnk wrote:
> Huh, ArrayRecord really doesn't include info about the dimensions... oh well.
Are you asking me to add that info or are you just commenting?


http://reviews.llvm.org/D21107





More information about the llvm-commits mailing list