[PATCH] D21131: [mips][ias] Implement N32 case for .cpsetup.

[Simon Dardis via llvm-commits]

sdardis requested changes to this revision.
sdardis added a comment.
This revision now requires changes to proceed.

This looks ok, but it acts unconditionally. In comparison GAS requires the -mno-shared to generate these style .cpsetup expansions as the resulting code cannot be put in a shared library.

This should only be enabled with a new command line flag -mno-shared.


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp:1094
@@ +1093,3 @@
+
+  if (getABI().IsN32()) {
+    MCSymbol *GPSym = MCA.getContext().getOrCreateSymbol("__gnu_local_gp");
----------------
Comment here on that it's a specific GNU extension / optimization for N32, off by default as it cannot be used to generate libraries.


http://reviews.llvm.org/D21131