[PATCH] D21128: [pdb] Fix errors with invalid stream numbers

[Zachary Turner via llvm-commits]

Is it because there are so many?  Or for a different reason?  There was one
case where there were like 15 lines of code jsut to get all the values out
of the functions and do the error checking, I found it really hurt the
ability to read the code.

I do agree that there are too many though.  I'm not a C++ wizard, but if
someone can help me figure out how to write them with fewer macros, do you
think that would be better?

On Wed, Jun 8, 2016 at 8:06 AM Rui Ueyama <ruiu at google.com> wrote:

> ruiu added a comment.
>
> I think I honestly don't like these macros. They indeed reduces amount of
> code but are hard to read. I prefer the current style (explicitly writing
> control flow in a plain C++) over the magical macros.
>
>
> http://reviews.llvm.org/D21128
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160608/4e6dfa32/attachment.html>