[PATCH] D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 08:02:23 PDT 2016


On 06/08, Matthias J. Reisinger wrote:
> mreisinger added a subscriber: mreisinger.
> 
> ================
> Comment at: include/polly/ScopInfo.h:2490
> @@ -2491,1 +2489,3 @@
> +  /// @brief The ScopBuilder pointer which is used to construct a Scop.
> +  std::unique_ptr<ScopBuilder> SI;
>  
> ----------------
> Maybe we should also rename this member from `SI` to `SB` then, to avoid confusion. I apologize for commenting after this patch has already been merged, unfortunately I've noticed this too late.
Good point and not too late :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160608/cc49ece7/attachment.sig>


More information about the llvm-commits mailing list