[PATCH] D20371: [llc] Remove exit-on-error flag from MIR tests (PR27770)

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 05:01:48 PDT 2016


rengolin added inline comments.

================
Comment at: tools/llc/llc.cpp:264
@@ -264,4 +263,3 @@
+      if (MIR)
         M = MIR->parseLLVMModule();
     } else
----------------
Can you guarantee parseLLVMModule won't return a null pointer?

I mean, it's pretty unlikely, but I'm surprised that this was asserting and being the only reason the *whole* test was "passing".


http://reviews.llvm.org/D20371





More information about the llvm-commits mailing list