[polly] r270054 - Move internal enum out of class declaration [NFC]
Johannes Doerfert via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 8 02:05:56 PDT 2016
On 06/07, Tobias Grosser wrote:
> On 05/19/2016 02:36 PM, Johannes Doerfert via llvm-commits wrote:
> > Author: jdoerfert
> > Date: Thu May 19 07:36:43 2016
> > New Revision: 270054
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=270054&view=rev
> > Log:
> > Move internal enum out of class declaration [NFC]
>
> Nice cleanup.
>
> > Modified:
> > polly/trunk/include/polly/ScopDetection.h
> > polly/trunk/lib/Analysis/ScopDetection.cpp
> >
> > Modified: polly/trunk/include/polly/ScopDetection.h
> > URL: http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/ScopDetection.h?rev=270054&r1=270053&r2=270054&view=diff
> > ==============================================================================
> > --- polly/trunk/include/polly/ScopDetection.h (original)
> > +++ polly/trunk/include/polly/ScopDetection.h Thu May 19 07:36:43 2016
> > @@ -203,13 +203,6 @@ private:
> > AliasAnalysis *AA;
> > //@}
> >
> > - /// @brief Enum for coloring BBs in Region.
> > - ///
> > - /// WHITE - Unvisited BB in DFS walk.
> > - /// GREY - BBs which are currently on the DFS stack for processing.
> > - /// BLACK - Visited and completely processed BB.
> > - enum Color { WHITE, GREY, BLACK };
> > -
> > /// @brief Map to remember detection contexts for all regions.
> > using DetectionContextMapTy = DenseMap<BBPair, DetectionContext>;
> > mutable DetectionContextMapTy DetectionContextMap;
> >
> > Modified: polly/trunk/lib/Analysis/ScopDetection.cpp
> > URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Analysis/ScopDetection.cpp?rev=270054&r1=270053&r2=270054&view=diff
> > ==============================================================================
> > --- polly/trunk/lib/Analysis/ScopDetection.cpp (original)
> > +++ polly/trunk/lib/Analysis/ScopDetection.cpp Thu May 19 07:36:43 2016
> > @@ -1380,6 +1380,13 @@ void ScopDetection::emitMissedRemarks(co
> > }
> > }
> >
> > +/// @brief Enum for coloring BBs in Region.
> > +///
> > +/// WHITE - Unvisited BB in DFS walk.
> > +/// GREY - BBs which are currently on the DFS stack for processing.
> > +/// BLACK - Visited and completely processed BB.
> > +enum Color { WHITE, GREY, BLACK };
>
> You could probably even have moved this inside the function itself.
Feel free to do this yourself, it is not my code anyway.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160608/f47b4365/attachment.sig>
More information about the llvm-commits
mailing list