[PATCH] D20769: [IPRA] Interprocedural Register Allocation - Analysis Passes

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.

================
Comment at: lib/CodeGen/RegisterUsageInfo.cpp:65
@@ +64,3 @@
+
+  for (auto pair : RegMasks) {
+    OS << pair.first->getName() << " ";
----------------
`pair` is not coding-convention friendly.

Also you are iterating on a map that is keyed on pointer values, which does not provided any ordering guarantee. Even with names as keys, the map is unordered anyway.
You need to generate a vector and sort it first.

================
Comment at: test/CodeGen/Generic/reg-usage-info.ll:39
@@ +38,3 @@
+  %4 = load i32, i32* %retval, align 4
+  ret i32 %4
+}
----------------
This test is not OK, for the reasons I explained when I provided the other test (stability).


http://reviews.llvm.org/D20769