[PATCH] D21107: Generate codeview for array types

[Reid Kleckner via llvm-commits]

rnk added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:788
@@ +787,3 @@
+  uint64_t Size = Ty->getSizeInBits() / 8;
+  ArrayRecord Record(ElementTypeIndex, IndexType, Size, Ty->getName());
+  return TypeTable.writeArray(Record);
----------------
Huh, ArrayRecord really doesn't include info about the dimensions... oh well.

================
Comment at: test/DebugInfo/COFF/types-array.ll:46
@@ +45,3 @@
+; CHECK:   }
+; CHECK: ]
+
----------------
I'd also CHECK for the Local block to see that it gets the right array type.


http://reviews.llvm.org/D21107