[PATCH] D21049: [LibFuzzer] Fix some unit test crashes on OSX.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 17:05:33 PDT 2016


delcypher added a comment.

In http://reviews.llvm.org/D21049#451734, @kcc wrote:

> In http://reviews.llvm.org/D21049#451731, @delcypher wrote:
>
> > In http://reviews.llvm.org/D21049#451718, @kcc wrote:
> >
> > > That's way better, but can you try one more step? 
> > >  Move this into test/FuzzerUnittest.cpp
> >
> >
> > Putting
> >
> >   #define _LIBCPP_HAS_NO_ASAN
> >
> >
> > at the top of `test/FuzzerUnittest.cpp` seems to work. Unfortunately I can't guard that with `#if defined(_LIBCPP_VERSION)` because that doesn't seem to work unless I've included a header file from libc++ first.
>
>
> That's fine, I think. just put 
>  #define _LIBCPP_HAS_NO_ASAN // with a comment


Okay. Before going with that solution I need to check another test failure though. The `FuzzerMutate.ShuffleBytes2` unit test is failing (and has been since I started working on LibFuzzer) and I haven't looked into why yet. Hopefully that won't be tricky to debug.


http://reviews.llvm.org/D21049





More information about the llvm-commits mailing list