[PATCH] D17573: [X86] PR26554: Use not all set of alternative nops in 64 bit mode, but only those which are correct

[Eric Christopher via llvm-commits]

echristo requested changes to this revision.
echristo added a comment.
This revision now requires changes to proceed.

I don't think that MCAsmBackend is the right place for storing this information (and so the rest of the change is also not OK).

Taking a step back this needs to be looked at from two directions:

a) overall module/.o specific things
b) subtarget specific things

The problem is that the way the patch is written you're using the base subtarget all the time and not taking into account any other ones at the function level. So your nops won't vary depending on which function is requesting which cpu.

What I think we'll want to do is take writeNopData off of MCAsmBackend and work it into something that already has the subtarget and then for global nop data we'll use the default subtarget that comes with the module.

Make sense?


http://reviews.llvm.org/D17573