[PATCH] D21078: [Thumb] Select a BIC instead of AND if the immediate can be encoded more optimally negated

[Chad Rosier via llvm-commits]

mcrosier added inline comments.

================
Comment at: lib/Target/ARM/ARMISelDAGToDAG.cpp:2799
@@ -2798,2 +2798,3 @@
       return;
 
+    auto *N1C = dyn_cast<ConstantSDNode>(N->getOperand(1));
----------------
Please add a very brief description here similar to what is in your summary.

================
Comment at: lib/Target/ARM/ARMISelDAGToDAG.cpp:2808
@@ +2807,3 @@
+      // handled by the generic ISel machinery.
+      bool ImmTransform =
+          Subtarget->hasThumb2() && !is_t2_so_imm(Imm) && is_t2_so_imm_not(Imm);
----------------
How about 'TransformImm', 'UseBIC' or 'PreferBIC'?


Repository:
  rL LLVM

http://reviews.llvm.org/D21078