[polly] r271890 - [NFC] Refactor assumption tracking interface

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 09:43:39 PDT 2016


On 06/06/2016 02:16 PM, Johannes Doerfert via llvm-commits wrote:
> Author: jdoerfert
> Date: Mon Jun  6 07:16:10 2016
> New Revision: 271890
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=271890&view=rev
> Log:
> [NFC] Refactor assumption tracking interface

NFC step-by-step improvements of the code are really nice.

A small suggestion for the future. Instead of the generic 'refactor', a
more concrete 'outline function' makes it clear why this new code is
an improvement.

As mentioned earlier, commit messages are a way to teach people about
our coding style. Being explicit about what kind of code you prefer in
your commit messages will allow new contributors such as our GSoC
students to learn from your changes.

Best,
Tobias


More information about the llvm-commits mailing list