[PATCH] D21049: [LibFuzzer] Fix some unit test crashes on OSX.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 23:29:26 PDT 2016


delcypher added a comment.

In http://reviews.llvm.org/D21049#450599, @kcc wrote:

> and, btw, I don't think we should be building the unit tests with asan. Or should we?


Unless in your unittests you need to interact with parts of the runtime provided by compiler-rt and/or need coverage to be tracked during execution of the unit tests then I would say you probably want ASan to ensure that LibFuzzer and the unit tests are built in the same way to avoid mixing ASan-ified and non-ASan-ified code.

I suspect that not building the unittests with ASan would fix this issue but I haven't tested that yet. I've only tried the other way (i.e building both LibFuzzer and the unittests with ASan).


http://reviews.llvm.org/D21049





More information about the llvm-commits mailing list