[PATCH] D20769: [IPRA] Interprocedural Register Allocation - Analysis Passes

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.

================
Comment at: lib/CodeGen/RegUsageInfoCollector.cpp:130
@@ +129,3 @@
+
+  PRUI->storeUpdateRegUsageInfo(Mdl->getNamedGlobal(MF.getName()),
+                                std::move(RegMask));
----------------
This is not the right API: `getNamedGlobal` is for global *variables*, not function.

================
Comment at: lib/CodeGen/RegisterUsageInfo.cpp:56
@@ +55,3 @@
+void PhysicalRegisterUsageInfo::storeUpdateRegUsageInfo(
+    const GlobalVariable* MFGlobalVar, std::vector<uint32_t> RegMask) {
+  RegMasks[MFGlobalVar] = std::move(RegMask);
----------------
Add an assertion that `MFGlobalVar` is not null (and the name isn't very explicit)


http://reviews.llvm.org/D20769