[PATCH] D20943: [LibFuzzer] [WIP] Declare and use sanitizer functions in `fuzzer::ExternalFunctions`
Dan Liew via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 6 18:17:26 PDT 2016
delcypher added inline comments.
================
Comment at: lib/Fuzzer/FuzzerDriver.cpp:272
@@ -271,2 +271,3 @@
assert(argc && argv && "Argument pointers cannot be nullptr");
- fuzzer::ExternalFunctions EF;
+ // We should have been called from main() so it should be safe
+ // to call Init() now.
----------------
kcc wrote:
> remove the comment, it makes little sense to me
The comment is stating something fairly important. It's stating that `Init` should be called after `main()`. It how is also stated in the `ExternalFunctions.h` header so I guess this is probably redundant. I'll remove it.
http://reviews.llvm.org/D20943
More information about the llvm-commits
mailing list