[PATCH] D20560: [new PM] port LoopAccessAnalysis to new pass manager (part-1)

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 17:44:49 PDT 2016


The renaming also makes the diff hard to read which I don't like either. I
will revert the renaming part.

thanks,

David

On Mon, Jun 6, 2016 at 5:29 PM, Chandler Carruth via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> chandlerc added a comment.
>
> The number of different changes here make it really hard to review.
>
> Can you instead actually send out the individual changes?
>
> I also don't see any benefit to renaming the file. I think the "Info"
> suffix, as common as it is in LLVM, is probably a mistake. I'm not sure its
> worth going and fixing everything to use a different suffix, but I like the
> current file name better than the one you propose here. (Just my opinion,
> if others have a different view from working more closely with the loop
> access stuff or vectorization stuff, totally fine with that...)
>
>
> http://reviews.llvm.org/D20560
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160606/5d7b3577/attachment.html>


More information about the llvm-commits mailing list