[PATCH] D21011: [codeview] Add complex record type translation
David Majnemer via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 6 16:37:27 PDT 2016
majnemer added inline comments.
================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1239-1243
@@ +1238,7 @@
+ Info.VBPOffset =
+ (InherTy->getOffsetInBits() >> 3) + InherInfo.VBPOffset;
+ Info.VirtualMethodsCount = InherInfo.VirtualMethodsCount;
+ } else {
+ Info.VBPOffset =
+ (InherTy->getOffsetInBits() + DDTy->getSizeInBits()) >> 3;
+ }
----------------
Please use / 8 here and elsewhere.
================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1255
@@ +1254,3 @@
+ for (auto *SPTy : I.second) {
+ bool found = false;
+ for (auto &VMTy : VirtualMethodsDst)
----------------
Please use the LLVM naming convention.
================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1591
@@ +1590,3 @@
+ if (Introduced)
+ VFTableOffset = SP->getVirtualIndex() * getPointerSizeInBits() >> 3;
+
----------------
Please parenthesize the subexpression.
http://reviews.llvm.org/D21011
More information about the llvm-commits
mailing list