[PATCH] D21038: AMDGPU/AsmParser: Add support for parsing symbol operands
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 6 14:30:45 PDT 2016
tstellarAMD marked an inline comment as done.
================
Comment at: lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:149
@@ +148,3 @@
+ StringRef getExpressionAsToken() const {
+ assert(isExpr());
+ const MCSymbolRefExpr *S = cast<MCSymbolRefExpr>(Expr);
----------------
It's not redundant, because Expr could be any of the MCExpr sub-classes. For example in the added tests case, Expr is sometimes an MCBinaryExpr.
http://reviews.llvm.org/D21038
More information about the llvm-commits
mailing list