[PATCH] D21041: [GVN] PRE can't hoist loads across calls in general.

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 14:19:21 PDT 2016


eli.friedman created this revision.
eli.friedman added reviewers: chandlerc, dberlin, reames, sanjoy.
eli.friedman added a subscriber: llvm-commits.

Issue exposed by noalias or more aggressive alias analysis.

I'm not particularly happy with the extra loop this patch adds, but I'm
not sure how to go about fixing it.

I'm also not very happy with the use of mayHaveSideEffects; we only care
specifically about control flow here.

http://reviews.llvm.org/D21041

Files:
  lib/Transforms/Scalar/GVN.cpp
  test/Transforms/GVN/pre-load.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21041.59784.patch
Type: text/x-patch
Size: 3607 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160606/5c007446/attachment.bin>


More information about the llvm-commits mailing list