[PATCH] D21024: [llvm-readobj] - Teach llvm-readobj to dump .gnu.version_r sections

[Rafael Ávila de Espíndola via llvm-commits]

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with nits.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:583
@@ +582,3 @@
+  StringRef Name = unwrapOrError(Obj->getSectionName(Sec));
+  W.printNumber("Section Name", Name, Sec->sh_name);
+  W.printHex("Address", Sec->sh_addr);
----------------
I don't think this should print Name/Address/Offset/Link. They are available from -s.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:603
@@ +602,3 @@
+    W.printNumber("Version", Need->vn_version);
+    W.printNumber("Count", Need->vn_cnt);
+    W.printString("Name",
----------------
Not sure we need to print vn_cnt, since we print vn_cnt entries.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:604
@@ +603,3 @@
+    W.printNumber("Count", Need->vn_cnt);
+    W.printString("Name",
+                  StringRef((const char *)(Obj->base() + StrTab->sh_offset +
----------------
FileName maybe?

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:613
@@ +612,3 @@
+      W.printNumber("Hash", Aux->vna_hash);
+      W.printNumber("Flags", Aux->vna_flags);
+      W.printNumber("Index", Aux->vna_other);
----------------
Don't we want to expand this into an enum?


http://reviews.llvm.org/D21024