[PATCH] D21034: [sanitizer] Fix build for new GLIBC msghdr/cmsghdr definition

[Adhemerval Zanella via llvm-commits]

zatrazz added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.cc:1023
@@ -1015,2 +1022,3 @@
 CHECK_SIZE_AND_OFFSET(msghdr, msg_name);
+#if CHECK_SENDMSG_MEMBER
 CHECK_SIZE_AND_OFFSET(msghdr, msg_namelen);
----------------
eugenis wrote:
> You are disabling the test on older glibc. Why? It used to work just fine.
> 
That's not its intention, __GLIBC_PREREQ will only set to 0 if is not yet defined (mainly when it is built using interposed features.h that do not define it). 

================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.h:422
@@ -421,1 +421,3 @@
     struct __sanitizer_iovec *msg_iov;
+#ifndef __GLIBC_PREREQ
+#define __GLIBC_PREREQ(x, y) 0
----------------
eugenis wrote:
> This is too confusing. Please provide the entire msghdr & cmsghdr definitions for the three cases (be, le, pre-2.24) w/o conditional macros inside.
> 
Right, I will change it.


Repository:
  rL LLVM

http://reviews.llvm.org/D21034