[PATCH] D20852: [AMDGPU] Remove exit-on-error in test (PR27761)

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:692
@@ -691,2 +691,3 @@
   DAG.getContext()->diagnose(NoDynamicAlloca);
-  return SDValue();
+  auto Ops = {DAG.getIntPtrConstant(0, SDLoc()), Op.getOperand(0)};
+  return DAG.getMergeValues(Ops, SDLoc());
----------------
I would prefer not using getIntPtrConstant since I would like to remove it in general from LLVM. This would more preferrably be getConstant(-1, Op.getValueType())

================
Comment at: test/CodeGen/AMDGPU/promote-alloca-bitcast-function.ll:9
@@ -8,3 +8,3 @@
 
 ; CHECK: in function crash_call_constexpr_cast{{.*}}: unsupported call to function foo
 define void @crash_call_constexpr_cast() #0 {
----------------
I think this can now have a check for the second function's error


http://reviews.llvm.org/D20852