[PATCH] D17473: [LoopUnroll] Avoid unnecessary DT recomputation.
Michael Zolotukhin via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 6 12:45:37 PDT 2016
mzolotukhin added inline comments.
================
Comment at: llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp:579
@@ -534,1 +578,3 @@
+ else
+ DEBUG(DT->verifyDomTree());
----------------
mehdi_amini wrote:
> If DT is null, this will always break (the test will be false, the else branch taken, and the nullptr dereferenced).
> Clang can be smart and eliminate your null check as well, deducing that it is not possible for it to be null.
Good catch! Thank, Mehdi!
Repository:
rL LLVM
http://reviews.llvm.org/D17473
More information about the llvm-commits
mailing list