[PATCH] D20789: Consecutive memory access in Loop Vectorizer - fixed and simplified

[Michael Kuperstein via llvm-commits]

mkuper added inline comments.

================
Comment at: ../lib/Transforms/Vectorize/LoopVectorize.cpp:2140
@@ -2169,1 +2139,3 @@
+  // Induction operand is the index of the GEP, not a pointer.
   unsigned InductionOperand = getGEPInductionOperand(Gep);
+  if (InductionOperand != 1 ||
----------------
Are you planning to call this with more complex GEPs?
If not, I'm not sure I understand why we need to call getGEPInductionOperand(Gep) here. Isn't it guaranteed to return 1?

================
Comment at: ../lib/Transforms/Vectorize/LoopVectorize.cpp:2160
@@ +2159,3 @@
+    Last =
+    (C->getSCEVType() == scSignExtend || C->getSCEVType() == scZeroExtend)
+    ? C->getOperand() : Last;
----------------
The formatting here looks off.


Repository:
  rL LLVM

http://reviews.llvm.org/D20789