[patch] Drop support for creating $subs

Jim Grosbach via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 10:46:31 PDT 2016


> On May 31, 2016, at 7:03 AM, Iain Sandoe via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> 
>> On 27 May 2016, at 20:30, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>> 
>> They are created by the linker since OS X 10.5.
>> 
>> Cheers,
>> Rafael
>> <0001-Update-tests-to-use-at-least-darwin9.patch><0002-Drop-support-for-creating-stubs.patch>
> 
> There’s no technical objection from me (and I for one find the asm more readable without the stubs)
> 
> However, this does represent a change in policy (no longer supporting generation of objects in 10.4 format);
> 
> It might well be moot in that 10.4 native tools probably cannot consume current binaries anyway (because of the version load commands).  That’s definitely true of the “cctools” related tools (e.g. ar), right now I don’t have a 10.4 system up to check whether the ld from xcode 2.5 can link .o files with version load commands.

+Nick, so he can correct me if I get this horribly wrong or something. ;)

Policy-wise, this seems fine to me.

We’re not actively testing against the 10.4 linker or anything like that. We, generally speaking, care about the latest tools being able to produce executables (including dylibs and bundles) that can run on older systems. Mixing and matching tools from different releases isn’t a typical scenario. The introduction of new load commands is a good example of that.

> 
> Iain
> 
> 
> 
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list